-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct sourcemap with treeshake #1069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sxzz
force-pushed
the
dev
branch
2 times, most recently
from
July 16, 2024 21:02
115a451
to
57654f6
Compare
sxzz
approved these changes
Jul 16, 2024
The unit test failed after rebasing. Could you please fix it? |
@sxzz done! |
sxzz
changed the title
fix: fix incorrect sourcemap with --treeshake
fix: correct sourcemap with treeshake
Jul 17, 2024
🎉 This issue has been resolved in version 8.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on pr #890
related to issue #889 (comment)
fix incorrect use of
applySourceMap()
correct example: https://github.com/mozilla/source-map/blob/master/test/test-source-map-generator.js#L356-L362
set rollup treeshake output path to
./dist
, so thatsources
in sourcemap can refer to../src/index.ts
instead ofsrc/index.ts
closes #890, closes #889